Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Link up --physical and --special Z moves to complete their data #1048

Open
helblinglilly opened this issue Feb 24, 2024 · 1 comment
Open

Comments

@helblinglilly
Copy link
Contributor

helblinglilly commented Feb 24, 2024

The moves between 622 and 657, Z Moves, are usually identical to one another.

For example 623 is effectively the same as 622, with the only real difference being that one is physical, the other specia. I've not played S/M which is where I think this comes from - but I can understand the rational here.

The problem is that for the moves in that range id + 1 has Dummy Data in all of its Flavour Text entries. Could these be combined for completeness?

I also wanted to ask about the learned_by_pokemon fields on those moves (GMax as well). Is that data that's simply not been populated yet because of the sheer volume, or is this by choice? If every Pokémon of a certain type can temporarily use those?

@helblinglilly helblinglilly changed the title Link up --physical and --special moves to complete their data Link up --physical and --special Z moves to complete their data Feb 24, 2024
@GreatNovaDragon
Copy link
Contributor

I feel that learned_by_pokemon is by choice, cause z-moves and dyna-moves are not learned.

z-moves and dyna-moves are empowered version moves, this is achieved via the z-crystal hold item or the process of dynamaxing.

To reduce data duplikation, one could make an additional move_Damage class of "varies" cause the Z-Moves, Dyna-Moves and some other moves, do vary with that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants