Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Why isnt csv a submodule just like sprites and cries? #1044

Open
GreatNovaDragon opened this issue Feb 15, 2024 · 2 comments
Open

Why isnt csv a submodule just like sprites and cries? #1044

GreatNovaDragon opened this issue Feb 15, 2024 · 2 comments

Comments

@GreatNovaDragon
Copy link
Contributor

Question basically given in title, but why isnt the dex data in a submodule like cries and sprites?

pokeapi/pokedex exists, probably cause its cloned from veekun/pokedex, but then this repo could be used to track technical issues, and pokedex for content issues.

@Naramsim
Copy link
Member

Hi, originally everything was in this repo. And the images were served by our webserver, not github. When we decided to serve the images through github, we probably decided to move the sprites elsewhere, also to save space. No particular reason about why we still have the CSV here, but I'd keep them here for simplicity

@GreatNovaDragon
Copy link
Contributor Author

You cant argue for simplicity, and have two different implementations of the same thing.

Either have all the cries and sprites inside this repo with the csv data, or have the cries and sprites asweell as the csv data as submodules

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants