Existing users code refactoring #582
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
coldacid
force-pushed
the
user-refactoring
branch
from
11c0296
to
9274065
Compare
coldacid
force-pushed
the
user-refactoring
branch
from
eafabba
to
ecbe46a
Compare
coldacid
force-pushed
the
user-refactoring
branch
4 times, most recently
from
40cec85
to
8fe3a51
Compare
Put the `addUser()`, `deleteUser()`, `changeUserPassword()`, and `getUsers()` functions into their own file, out of misc/functions.php.
Create a class which will store details of an individual user. This will make it easier to store more information than just login credentials for users.
coldacid
force-pushed
the
user-refactoring
branch
from
8fe3a51
to
23699d6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #581