Skip to content
This repository has been archived by the owner on Feb 9, 2021. It is now read-only.

"moved" wrongly possibly fix #2799

Closed
vvzar opened this issue Mar 24, 2015 · 10 comments
Closed

"moved" wrongly possibly fix #2799

vvzar opened this issue Mar 24, 2015 · 10 comments
Assignees

Comments

@vvzar
Copy link

vvzar commented Mar 24, 2015

Can You please change line in file src/pocketmine/Player.php:
1360 - if($diffY > -0.5 or $diffY < 0.5){
1360 + if($diffY >= -0.5 or $diffY <= 0.5){

I think, this way stairs and other thin blocks will not generate "moved wrongly" issue :(

@shoghicp
Copy link
Member

oh. Well, now we only need to fix the thin vertical blocks like iron bars or glass panes, they are wrong. Also fences.

I'll check this tomorrow, I can't test right now!

@matcracker
Copy link
Contributor

Nice thing!

@PEMapModder
Copy link
Collaborator

Make a pull request.

@shoghicp
Copy link
Member

This does not fix the issue. Helps with detecting a problem, but without proper offset checks it's not useful. I've been experimenting with some other settings, but it'll be for 1.5

@vvzar
Copy link
Author

vvzar commented Mar 26, 2015

The reason i decided to provide this - in playing experience. While i moving up too slow on stairs "revert" doesnt happen. So I tried removing half-block distance the same as one stair from expression by giving to such movement zero speed.
Sorry for empty hope

@shoghicp
Copy link
Member

@vvzar The fix is correct, but doesn't fix all the things. It's only the first part :)

@thelucyclub
Copy link

😄

@tyan-boot
Copy link

it is a serious problem,hope for fixing it soon

@vvzar
Copy link
Author

vvzar commented Apr 12, 2015

in dev 1.5 builds warning seems to be fixed.
New possible mistake in height of mob or height between 2 blocks, or damage count. When i place mob citizen on carpet and above him roof of blocks - mob takes damage every second. Like inside wall or block.

@vvzar
Copy link
Author

vvzar commented Apr 13, 2015

Maybe we can count height of mob > 2 blocks == 2 blocks?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

7 participants