Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use assertion library for Pluto tests #585

Open
well-in-that-case opened this issue Dec 21, 2023 · 0 comments
Open

Use assertion library for Pluto tests #585

well-in-that-case opened this issue Dec 21, 2023 · 0 comments
Labels
enhancement New feature or request

Comments

@well-in-that-case
Copy link
Collaborator

well-in-that-case commented Dec 21, 2023

The assertion library is very helpful in some instances (table comparison), but it'll always be far more useful when an error case actually occurs due to significantly improved error messages.

This should be done slowly — possibly over dozens of commits — with great attention-to-detail for each test case we convert. It's imperative we ensure the assertion library does not contain any logic errors which corrupt our test integrity. There is no known fault in the library and Pluto's test cases for the library pass as expected, but it's not a time-tested library yet.

@well-in-that-case well-in-that-case added the enhancement New feature or request label Dec 21, 2023
@well-in-that-case well-in-that-case changed the title Rewriting tests to use assertion library Rewriting Pluto tests to use assertion library Dec 21, 2023
@well-in-that-case well-in-that-case self-assigned this Dec 29, 2023
@well-in-that-case well-in-that-case removed their assignment Apr 13, 2024
@well-in-that-case well-in-that-case changed the title Rewriting Pluto tests to use assertion library Use assertion library for Pluto tests Apr 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant