Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return ISlot instead of ulong from WaitForSlotEvent #175

Open
lo1ol opened this issue Jan 28, 2021 · 1 comment
Open

Return ISlot instead of ulong from WaitForSlotEvent #175

lo1ol opened this issue Jan 28, 2021 · 1 comment

Comments

@lo1ol
Copy link

lo1ol commented Jan 28, 2021

Hello,

I can create the patch with fix of returning slot type from WaitForSlotEvent. I think we have to return high level ISlot instead of ulong. Do you think it's a good idea or are there some problems with it that I didn't notice?

void WaitForSlotEvent(WaitType waitType, out bool eventOccured, out ulong slotId);

@jariq
Copy link
Member

jariq commented Jan 28, 2021

Sounds like an useful addition but I'm not sure about it right now.
It might be API breaking change so that is one thing to consider and I will also need to check the source to make sure it's OK and it won't break anything.
I'll need some time to think about it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants