Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Document/Code inconsistency] Location of Bootstrap info in USDC #1072

Closed
syoyo opened this issue Dec 27, 2019 · 3 comments
Closed

[Document/Code inconsistency] Location of Bootstrap info in USDC #1072

syoyo opened this issue Dec 27, 2019 · 3 comments

Comments

@syoyo
Copy link

syoyo commented Dec 27, 2019

Description of Issue

In the comment, it says Bootstrap is written at the end of file.

https://github.com/PixarAnimationStudios/USD/blob/master/pxr/usd/lib/usd/crateFile.h#L441

But the implementation(and existing USDC/USDZ) assumes bootstrap is placed at the beginning of file.

https://github.com/PixarAnimationStudios/USD/blob/master/pxr/usd/lib/usd/crateFile.cpp#L2498

So I think comment is wrong.
Or old version of USDC places Bootstrap data at the end of file?

Steps to Reproduce

System Information (OS, Hardware)

Package Versions

Build Flags
@gitamohr
Copy link
Contributor

You're right; that comment is incorrect. I'll fix it up -- thank you.

@jilliene
Copy link

jilliene commented Jan 6, 2020

Filed as internal issue #USD-5772

@sunyab sunyab added the pending release Issue addressed in next release label Mar 27, 2020
@syoyo
Copy link
Author

syoyo commented Apr 19, 2020

🎉

@sunyab sunyab removed the pending release Issue addressed in next release label Oct 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@syoyo @gitamohr @sunyab @jilliene