Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade TinyMCE to 6.7.0? #2019

Open
hellfirehd opened this issue Oct 12, 2023 · 2 comments
Open

Upgrade TinyMCE to 6.7.0? #2019

hellfirehd opened this issue Oct 12, 2023 · 2 comments

Comments

@hellfirehd
Copy link

Are there any plans to upgrade TinyMCE to v6.7.0?

In my own experimenting, It looks like the piranhaimage and piranhalink plugins will work without any modifications. The only significant changes are to:

  • _EditorConfig.cshtml - supply an array instead of a string:
- this.plugins = "@EditorConfig.Current.Plugins";
+ this.plugins = @EditorConfig.Current.Plugins();
  • An extension method to convert editorconfig.json plugins to an array:
public static IHtmlContent Plugins(this EditorConfig config)
{
  var plugins = config.Plugins.Split(' ', StringSplitOptions.TrimEntries | StringSplitOptions.RemoveEmptyEntries);
  return new HtmlContentBuilder().AppendHtml(JsonConvert.SerializeObject(plugins));
}

Also, TinyMCE v6.7.0 no longer includes jquery.tinymce.min.js but this does not appear to be used by PiranhaCMS.

Thoughts?

hellfirehd added a commit to DougKWilson/piranha.core that referenced this issue Oct 12, 2023
@tidyui
Copy link
Member

tidyui commented Oct 26, 2023

Hi there! We will definitely look into this for the next upcoming major which is planned for .NET 8

@tidyui
Copy link
Member

tidyui commented Apr 13, 2024

This didn't make it in version 11.0, but we'll look at the version available together with possible changes in the open source license.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants