Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove uses of replaceAll that don't work on older devices/browsers #513

Closed
wants to merge 2 commits into from

Conversation

mgabor3141
Copy link

@mgabor3141 mgabor3141 commented Dec 11, 2022

This PR fixes #411

Tested and the button is now working on my old Nexus 7, where it wasn't working before.

@FHeilmann
Copy link

@mgabor3141 could you send me the artifact of your build? I was hoping to fix this on my end as well.

@PiotrMachowski
Copy link
Owner

@FHeilmann artifacts are available here

@FHeilmann
Copy link

@FHeilmann artifacts are available here

I must be blind. Thanks a lot! :)

@PiotrMachowski PiotrMachowski changed the base branch from master to dev January 27, 2023 03:36
@PiotrMachowski
Copy link
Owner

PiotrMachowski commented Jan 27, 2023

@mgabor3141 I think I would prefer to use a polyfill instead (e.g. this one)

@nios87
Copy link

nios87 commented Feb 17, 2023

I'm in the same boat. Older Android device. Will this be merged ?

@snios
Copy link

snios commented Feb 19, 2023

@mgabor3141 I think I would prefer to use a polyfill instead (e.g. this one)

I did try that polyfill but sadly it did not work. So if anyone has a very good polyfill and is used to working with polyfills feel free to pitch in. Otherwise the quick solution would be to use replace instead of replaceAll for comapbility with older browsers?

@PiotrMachowski
Copy link
Owner

@snios which device do you have?

@snios
Copy link

snios commented Feb 19, 2023

@PiotrMachowski
Chrome 81.0.4044.138 on Android 4.2.2

@PiotrMachowski
Copy link
Owner

Woah, that's pretty ancient... Does HA work for you without any problems?

@snios
Copy link

snios commented Feb 19, 2023

Woah, that's pretty ancient... Does HA work for you without any problems?

No problem actually :) That is what i like about HA it can work on low end devices and old devices. And for the front end especially i think that is something to relly keep in mind when developing :)

That beeing said i do know that it is a really old device :) and i can shimmy a fix for this my self locally :)

@PiotrMachowski
Copy link
Owner

@snios can you check which ES version does your browser support? (using this snippet)

@PiotrMachowski
Copy link
Owner

Ok, I'll close this PR because it doesn't actually fix the problem in all places (usage in utils.ts is incorrectly migrated). I have tried to make it work with a polyfill instead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unable to Press Start on Tizen Browser
5 participants