-
-
Notifications
You must be signed in to change notification settings - Fork 243
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: remove uses of replaceAll that don't work on older devices/browsers #513
Conversation
replaceAll now throws error on build
@mgabor3141 could you send me the artifact of your build? I was hoping to fix this on my end as well. |
@FHeilmann artifacts are available here |
I must be blind. Thanks a lot! :) |
@mgabor3141 I think I would prefer to use a polyfill instead (e.g. this one) |
I'm in the same boat. Older Android device. Will this be merged ? |
I did try that polyfill but sadly it did not work. So if anyone has a very good polyfill and is used to working with polyfills feel free to pitch in. Otherwise the quick solution would be to use replace instead of replaceAll for comapbility with older browsers? |
@snios which device do you have? |
@PiotrMachowski |
Woah, that's pretty ancient... Does HA work for you without any problems? |
No problem actually :) That is what i like about HA it can work on low end devices and old devices. And for the front end especially i think that is something to relly keep in mind when developing :) That beeing said i do know that it is a really old device :) and i can shimmy a fix for this my self locally :) |
@snios can you check which ES version does your browser support? (using this snippet) |
Ok, I'll close this PR because it doesn't actually fix the problem in all places (usage in |
This PR fixes #411
Tested and the button is now working on my old Nexus 7, where it wasn't working before.