Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is it possible to add option to use three columns? #9

Open
orenpapers opened this issue Feb 20, 2020 · 5 comments
Open

Is it possible to add option to use three columns? #9

orenpapers opened this issue Feb 20, 2020 · 5 comments

Comments

@orenpapers
Copy link

to have multi-categories flow?

@Pierre-Sassoulas
Copy link
Owner

It's probably a big change and even a completely different function to implement than the existing one, but it would be a nice feature indeed.

@wspr
Copy link

wspr commented Apr 4, 2024

Before I realised there were other active forks (sorry!), I started expanding the scope of the original pysankey code here:

https://github.com/AUMAG/ausankey/

This allows multiple “stages” or columns of data to draw flows between as well as some additional options for formatting and labelling.

@Pierre-Sassoulas
Copy link
Owner

Mind opening a pull request to reconcile the two forks ?

@wspr
Copy link

wspr commented Apr 4, 2024

@Pierre-Sassoulas — sadly I didn’t do my research before starting my fork (honestly I didn’t go into it with a plan to develop a whole thing, just to tinker — and then things got out of hand)

Because I started from the original repo, we diverged from the start, and the code is almost unrecognisable now. Some of the interfaces are also different (I wasn’t worried about backwards compatibility). So I’m not sure a pull request would even make sense at this point…

@Pierre-Sassoulas
Copy link
Owner

If it's a new function entirely we can put it alongside the other one. I was thinking of doing a v2 at some point but yeah retro-compat was a high priority (to be able to say "use this it fixes the issue" without bringing a migration into the mix).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants