Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Reactor thread locals propagation #20

Open
nathankooij opened this issue Mar 22, 2018 · 1 comment
Open

Add support for Reactor thread locals propagation #20

nathankooij opened this issue Mar 22, 2018 · 1 comment
Assignees

Comments

@nathankooij
Copy link

nathankooij commented Mar 22, 2018

Current module is not sufficient for Reactor because it does not provide support for decorating Callables which are used by Reactor's schedulers. Moreover, we can leverage Reactor's subscriber context mechanism to ensure propagation whenever Reactor's schedulers are not used (e.g. Netty and the Reactive Mongo driver use their own event-driven scheduling mechanism).

@nathankooij nathankooij self-assigned this Mar 22, 2018
@bsideup
Copy link

bsideup commented Dec 2, 2019

not sufficient for Reactor because it does not provide support for decorating Callables which are used by Reactor's schedulers

FYI starting from Reactor 3.3, there is Schedulers.onScheduleHook() to do so. And, before 3.3, there was Schedulers.addExecutorServiceDecorator() for it.

Although I agree that using Reactor's Context is the best way to achieve it 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants