Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Undistort pitch/yaw for colored shape targets #1242

Open
PascalSkylake opened this issue Feb 18, 2024 · 3 comments
Open

Undistort pitch/yaw for colored shape targets #1242

PascalSkylake opened this issue Feb 18, 2024 · 3 comments
Labels
enhancement New feature or request

Comments

@PascalSkylake
Copy link

I've been trying to use photonvision for detecting game pieces, but there is significant error when getting pitch and yaw because of lens distortion, making the absolute position of the game pieces change as the camera rotates.

I left a comment about this a little while ago on an issue from 2022, but that issue was only somewhat related.

@PascalSkylake PascalSkylake added the enhancement New feature or request label Feb 18, 2024
@mcm001
Copy link
Contributor

mcm001 commented Feb 18, 2024

Is this for colored shape or also for ML results? Either way yeah agreed. What lens FOV do you have?

@PascalSkylake
Copy link
Author

PascalSkylake commented Feb 19, 2024

I'm asking specifically for colored shape, but I imagine the process wouldn't be too different? Off the top of my head the camera is 65 degrees hfov, I can send actual calibration results tomorrow if that'd help, but the issue is present on every camera I've tried.

edit, didnt mean to close the issue my bad

@mcm001
Copy link
Contributor

mcm001 commented Feb 21, 2024

#1250 has the start of this. I'm scared to touch critical code like this so late in the season, though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants