"Download images for all games" includes (invalid) games on other accounts

[idbrii]

Describe the bug
"Download images for all games" downloaded images for 500+ games when on a few were missing images. It should have taken a second but took a minute because it seems to be downloading far more than I want.

It appears that it's downloading images for games that aren't on the selected steam account. But the button is on a page of information for the current steam account.

To Reproduce
Steps to reproduce the behavior:

1. Sign in to steam account B
2. Install a few game shortcuts (I did it with steamsync, but should be the same with boilr)
3. Change to steam account A
4. Install one more game.
5. Run Boilr and select B's user id
6. Click on "Download images for all games"
7. Downloads images for A's games which aren't seen in the list

Expected behavior
If the images are already downloaded, there's no point in downloading them again. It also makes me worry that if I manually set an image for a game it will get cleared.

Screenshots

This is after the download process ran. I didn't think quick enough to capture the "Downloading 584 images" text.

The placement of "Download images for all games" looks like it'd apply to the above games.

Desktop (please complete the following information):

• OS: Windows 10
• BoilR Version v.1.7.22
• Launcher: Steam

The log says:

Checking for game images
Searching for JungleJaguar
Searching for Broforce
Searching for Sea of Stars
Downloading Logo for Ape Out to "C:\\idbrii\\apps\\steam\\userdata\\000steamidC\\config\\grid\\0_logo.png"
Downloading Logo for Kodi to "C:\\idbrii\\apps\\steam\\userdata\\000steamidC\\config\\grid\\0_logo.png"
Downloading Logo for Unavowed to "C:\\idbrii\\apps\\steam\\userdata\\000steamidC\\config\\grid\\0_logo.png"
Downloading Logo for Thumper to "C:\\idbrii\\apps\\steam\\userdata\\000steamidC\\config\\grid\\0_logo.png"
Downloading Logo for Grounded to "C:\\idbrii\\apps\\steam\\userdata\\000steamidC\\config\\grid\\0_logo.png"

<removed many lines here>

Downloading Grid for Tetris® Effect: Connected to "C:\\idbrii\\apps\\steam\\userdata\\000steamidB\\config\\grid\\0p.png"
Downloading Grid for Spiritfarer to "C:\\idbrii\\apps\\steam\\userdata\\000steamidB\\config\\grid\\0p.png"
Error downloading "C:\\idbrii\\apps\\steam\\userdata\\000steamidB\\config\\grid\\0p.png": error sending request for url (https://cdn2.steamgriddb.com/file/sgdb-cdn/grid/fd73d9e039609042b9532f83ea3e3ae5.png): error trying to connect: unexpected EOF during handshake
Error downloading "C:\\idbrii\\apps\\steam\\userdata\\000steamidB\\config\\grid\\0p.png": error sending request for url (https://cdn2.steamgriddb.com/file/sgdb-cdn/grid/fd73d9e039609042b9532f83ea3e3ae5.png): error trying to connect: unexpected EOF during handshake
Error downloading "C:\\idbrii\\apps\\steam\\userdata\\000steamidB\\config\\grid\\0p.png": error sending request for url (https://cdn2.steamgriddb.com/file/sgdb-cdn/grid/fd73d9e039609042b9532f83ea3e3ae5.png): error trying to connect: unexpected EOF during handshake
Error downloading "C:\\idbrii\\apps\\steam\\userdata\\000steamidB\\config\\grid\\0p.png": error sending request for url (https://cdn2.steamgriddb.com/file/sgdb-cdn/grid/fd73d9e039609042b9532f83ea3e3ae5.png): error trying to connect: unexpected EOF during handshake
Error downloading "C:\\idbrii\\apps\\steam\\userdata\\000steamidB\\config\\grid\\0p.png": error sending request for url (https://cdn2.steamgriddb.com/file/sgdb-cdn/grid/fd73d9e039609042b9532f83ea3e3ae5.png): error trying to connect: unexpected EOF during handshake
Error downloading "C:\\idbrii\\apps\\steam\\userdata\\000steamidB\\config\\grid\\0p.png": error sending request for url (https://cdn2.steamgriddb.com/file/sgdb-cdn/grid/fd73d9e039609042b9532f83ea3e3ae5.png): error trying to connect: unexpected EOF during handshake
Downloading Grid for Astroneer to "C:\\idbrii\\apps\\steam\\userdata\\000steamidB\\config\\grid\\0p.png"
Downloading WideGrid for Ape Out to "C:\\idbrii\\apps\\steam\\userdata\\000steamidB\\config\\grid\\0.png"
Error downloading "C:\\idbrii\\apps\\steam\\userdata\\000steamidB\\config\\grid\\0p.png": error sending request for url (https://cdn2.steamgriddb.com/file/sgdb-cdn/grid/fd73d9e039609042b9532f83ea3e3ae5.png): channel closed
Error downloading "C:\\idbrii\\apps\\steam\\userdata\\000steamidB\\config\\grid\\0p.png": error sending request for url (https://cdn2.steamgriddb.com/file/sgdb-cdn/grid/fd73d9e039609042b9532f83ea3e3ae5.png): channel closed
Downloading WideGrid for Kodi to "C:\\idbrii\\apps\\steam\\userdata\\000steamidB\\config\\grid\\0.png"

<removed many lines here>

Downloading Logo for Sea of Stars to "C:\\idbrii\\apps\\steam\\userdata\\000steamidA\\config\\grid\\2842244788_logo.png"
Downloading Hero for Aladdin to "C:\\idbrii\\apps\\steam\\userdata\\000steamidA\\config\\grid\\3160885078_hero.png"
Downloading Hero for Broforce to "C:\\idbrii\\apps\\steam\\userdata\\000steamidA\\config\\grid\\4036473157_hero.png"
Downloading Hero for Sea of Stars to "C:\\idbrii\\apps\\steam\\userdata\\000steamidA\\config\\grid\\2842244788_hero.png"
Downloading Grid for Broforce to "C:\\idbrii\\apps\\steam\\userdata\\000steamidA\\config\\grid\\4036473157p.png"
Downloading Grid for Sea of Stars to "C:\\idbrii\\apps\\steam\\userdata\\000steamidA\\config\\grid\\2842244788p.png"
Downloading WideGrid for Aladdin to "C:\\idbrii\\apps\\steam\\userdata\\000steamidA\\config\\grid\\3160885078.png"
Downloading WideGrid for Broforce to "C:\\idbrii\\apps\\steam\\userdata\\000steamidA\\config\\grid\\4036473157.png"
Downloading WideGrid for Sea of Stars to "C:\\idbrii\\apps\\steam\\userdata\\000steamidA\\config\\grid\\2842244788.png"
Downloading Icon for Aladdin to "C:\\idbrii\\apps\\steam\\userdata\\000steamidA\\config\\grid\\3160885078-icon.png"
Downloading Icon for Broforce to "C:\\idbrii\\apps\\steam\\userdata\\000steamidA\\config\\grid\\4036473157-icon.ico"
Downloading Icon for Sea of Stars to "C:\\idbrii\\apps\\steam\\userdata\\000steamidA\\config\\grid\\2842244788-icon.ico"
Finished getting images in: 52.7822995s

The three it lists as "Searching for" are the ones I'd expect it to download since they're missing images. The first ones it lists as "Downloading" I don't even have installed, but I have previously installed them (You can see they're not in the screenshot). I checked steamidB's shortcuts.vdf and it does list a bunch of games that aren't on steamidA (like Spiritfarer).

Seems like there's two issues:

• a bug where it detects games and downloads with id 0 even though that's invalid and will never work.
• I want the behaviour "Download missing images for all visible games" (not other steam accounts).

[Kaympe20]

With your visible library, 584 isn't outrageous as each game requires 5 pictures.

[idbrii]

But it still shouldn't download images for multiple games to the same file path (0.png). There's no point.