Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SwordBlockingHack Sending an object which is not a packet #16

Open
I-Al-Istannen opened this issue Dec 28, 2019 · 0 comments
Open

SwordBlockingHack Sending an object which is not a packet #16

I-Al-Istannen opened this issue Dec 28, 2019 · 0 comments

Comments

@I-Al-Istannen
Copy link

Description

Here you send a PacketContainer instead of the underlying packet (event.addPacketAfter(packet.deepClone()) instead of event.addPacketAfter(packet.deepClone().handle)).
This causes problem with our plugin, OldCombatMechanics.

Related issues

kernitus/BukkitOldCombatMechanics#355
ProtocolSupport/ProtocolSupport#1187

Mitigation

I have not looked at your code in-depth enough to tell if the above is correct, but it solves the problem and if I understand what addPacketAfter does correctly, it should be correct.

I will also add a mitigation in OCM that just ignores other classes (maybe silently) to stop OCM from crashing, but the proper fix should be done here, IMHO.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant