Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Temporarily swap the backprop tutorial to use Autograd #258

Merged
merged 2 commits into from Apr 23, 2021
Merged

Temporarily swap the backprop tutorial to use Autograd #258

merged 2 commits into from Apr 23, 2021

Conversation

josh146
Copy link
Member

@josh146 josh146 commented Apr 23, 2021 •
edited

Fixes #256, so that the demo continues to make sense while we determine the cause of the TensorFlow slowdown

image

mariaschuld
mariaschuld approved these changes Apr 23, 2021
View reviewed changes
Copy link
Contributor

@mariaschuld mariaschuld left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I actually like it this way, it kind of doesn't suggest that TF is needed for backprop.

There was only one typo to fix.

@josh146 @mariaschuld
Apply suggestions from code review
83fc75d 
Co-authored-by: Maria Schuld <mariaschuld@gmail.com>
@josh146
Copy link
Member Author

josh146 commented Apr 23, 2021

Thanks @mariaschuld!

@josh146 josh146 merged commit 3c35698 into master Apr 23, 2021
@josh146 josh146 deleted the fix-backprop branch April 23, 2021 10:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mariaschuld mariaschuld mariaschuld approved these changes

@glassnotes glassnotes Awaiting requested review from glassnotes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] TensorFlow version of the backprop tutorial is producing incorrect benchmarks
2 participants
@josh146 @mariaschuld