Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Limit CuBIDS filename changes to the acq entity and datatype folder #301

Open
tsalo opened this issue Feb 12, 2024 · 1 comment
Open

Limit CuBIDS filename changes to the acq entity and datatype folder #301

tsalo opened this issue Feb 12, 2024 · 1 comment
Assignees
Labels
breaking-change enhancement New feature or request

Comments

@tsalo
Copy link
Member

tsalo commented Feb 12, 2024

Summary

Currently, CuBIDS has the entities that may exist in output filenames hardcoded. If we instead choose to limit CuBIDS to the acq entity (which is how we label variants), then we can just use whatever entities were in the original filenames.

This will primarily affect CuBIDS.change_filename. I'm not sure how it would impact the key/parameter/acquisition group grouping process.

Additional details

Simpler code, more generalizability.

@tsalo tsalo added enhancement New feature or request breaking-change labels Feb 12, 2024
@tsalo tsalo self-assigned this Feb 12, 2024
@mattcieslak
Copy link
Contributor

Discussed at informatics meeting 2/12/24, we agree

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking-change enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants