Gcc8 support #16
Closed
Gcc8 support #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added a flag for <filesystem> support on gcc8
added support to <filesystem> for gcc8 also in link phase
Pengor
requested changes
May 24, 2021
| @@ -4,9 +4,12 @@ project(chia-log-analysis VERSION 0.5) | |||
|
|
|||
| set(CMAKE_CXX_STANDARD 17) | |||
| set(CMAKE_CXX_STANDARD_REQUIRED True) | |||
| set(CMAKE_CXX_FLAGS "-lstdc++fs") | |||
There was a problem hiding this comment.
This flag should only be set when the compiler is GCC and the GCC version is 8.x, otherwise it is passed to other compilers that report warnings.
| target_include_directories(chia-log-analysis PUBLIC "${PROJECT_BINARY_DIR}") | ||
| target_include_libraries(chia-log-analysis PUBLIC -lstdc++fs) |
There was a problem hiding this comment.
When running cmake -S src -B build with this line I get the following error under my environments (msvc 16 & gcc 10, cmake 3.20):
CMake Error at CMakeLists.txt:15 (target_include_libraries):
Unknown CMake command "target_include_libraries".
|
Thanks for the PR @pacio5! Let me know if you'd like to continue working on this issue, otherwise I can look into it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It solves the problem of working with gcc8. Enables support for .