Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When SignedData is parsed from a Buffer, .verify() fails to select the right signer certificate in the 3.0.15 release build #382

Open
sander opened this issue Aug 18, 2023 · 0 comments

Comments

@sander
Copy link

sander commented Aug 18, 2023

Example: https://github.com/sander/pkijs-buffer-bug

Hypothesis: when searching through SignedData.certificates, any IssuerAndSerialNumber.serialNumber from the same Buffer matches, since the Integer.isEqual check compares the whole buffer content instead of just the slices. I faced similar issues in: PeculiarVentures/pvtsutils#13.

I could not reproduce this from within the PKI.js repository or with a local npm build artifact from 80afe52. So possibly the bug is caused by the particular build process that was used to release 3.0.15.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant