Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Honor CheckDate Optionality in the CertificateChainValidationEngine #362

Open
sujith-k-s opened this issue Aug 24, 2022 · 2 comments
Open
Assignees

Comments

@sujith-k-s
Copy link

We have a case where we do not want to verify the Validity Periods of the Certificates. Passing an undefined to the CheckDate Parameter should honor this and should not check for the validity of the certificates. I understand that this could break current implementations, therefore we could add an additional argument (validateDate) to parameters which would produce the same result. The only change required for this on line 415, where you do:

if (this.validateDate && (crl.nextUpdate && crl.nextUpdate.value < this.checkDate)) {

@rmhrisk
Copy link
Contributor

rmhrisk commented Aug 25, 2022

What is the use case?

@microshine
Copy link
Contributor

Looks very strange. You don't want to verify the Validity Periods of the Certificate, but use CRLs for path building (which require checkDate argument). Would it be easier to build the chain without Revocation Lists and use the date (notBefore or notAfter) from the leaf certificate?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants