Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Running CI and Renderbook workflow only for merge request, merge queue and Master Branch #3187

Open
GandalfGwaihir opened this issue Jun 15, 2023 · 0 comments · May be fixed by #3216
Open

Comments

@GandalfGwaihir
Copy link
Collaborator

Description

Is your feature request related to a problem? Please describe.

Currently the workflow goes like, on approval of a PR, we go on to put the PR in the merge group where workflow will get triggered and then when the PR will get merged, a second workflow will get triggered.

Proposed Solution

Describe the solution you'd like

I was proposing that we skip the Renderbook and CI tests on it's merge with the develop branch as the tests would already have been passed in the merge group.

No need to update the Docker workflow as it will publish the latest images on DockerHub once we merge the PR onto the develop branch.

But the workflow for CI and Renderbook might be skipped as for CI we do not publish it anywhere and for Renderbook, it gets published to github in the merge queue itself (Example).

For CI and Renderbook workflow, I am proposing:

on:
  push:
    branches:
      - master

Instead of:

on:
  push:
    branches:
      - master
      - develop

Additional Context

Shall I make a Pull Request updating these changes?

@GandalfGwaihir GandalfGwaihir linked a pull request Sep 9, 2023 that will close this issue
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant