build: Test Models Against the Full Docker Stack #3183
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
infotroph
reviewed
Jun 13, 2023
GandalfGwaihir
force-pushed
the
Docker-Stack-Testing
branch
from
92ff4ac
to
f27780a
Compare
GandalfGwaihir
commented
Jun 14, 2023
| @@ -300,6 +300,7 @@ services: | |||
| api: | |||
| image: pecan/api:${PECAN_VERSION:-latest} | |||
| user: "${UID:-1001}:${GID:-1001}" | |||
| restart: unless-stopped | |||
There was a problem hiding this comment.
It can be useful to automatically restart the api container if it ever fails when we bring up the whole docker stack
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In this PR, we have used the full docker stack to test SIPNET by using Docker Compose, this test will run weekly on Mondays.
Motivation and Context
From Discussions in #3184, It would be wise to have a script file and have our cURL POST requests for different models in it as the Matrix option would have to bring up the whole docker stack for each job of the Matrix.
In this PR, we have added the SIPNET model test, which outputs the sipnet.out (model output) file, Test results can be found in this workflow
In the script file, template has been provided to correctly input data into the cURL request so that in future, People can add more models in the script file against which tests can be performed.
Review Time Estimate
Types of changes
Checklist:
This PR closes #3184