Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test RabbitMQ following #3025 #3088

Open
dlebauer opened this issue Jan 12, 2023 · 5 comments
Open

Test RabbitMQ following #3025 #3088

dlebauer opened this issue Jan 12, 2023 · 5 comments

Comments

@dlebauer
Copy link
Member

The final task for #3025 was to test that it still works using RabbitMQ. Rather than holding up the PR, I am opening this issue for @robkooper to go back and test that the system still works with RabbitMQ.

We should also address the question:

  • is there a way to automatically test this feature using GH actions?
  • does the fact that a PR is blocked by the need for a manual test indicate an undesirable pattern?
@Aariq
Copy link
Collaborator

Aariq commented Jan 13, 2023

Not sure, but this might help with testing: https://github.com/marketplace/actions/rabbitmq-in-github-actions

@robkooper
Copy link
Member

other option is to bring up the full stack using docker and run a single test through curl. same as the current sipnet test (which runs with local install). See https://github.com/PecanProject/pecan/actions/runs/3893869709/workflow#L143

@robkooper
Copy link
Member

tested with rabbitmq, it works

@robkooper
Copy link
Member

do you want to rename this issue or should we open a a new issue that is specific for more complex testing.

Copy link

This issue is stale because it has been open 365 days with no activity.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants