Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Web3 #18

Open
drvillo opened this issue Nov 21, 2018 · 1 comment
Open

Update Web3 #18

drvillo opened this issue Nov 21, 2018 · 1 comment

Comments

@drvillo
Copy link

drvillo commented Nov 21, 2018

Hi @PaulLaux we could potentially contribute a PR to update Web3 to 1.0 and I'd like to check if you had done any previous analysis on how that would work, considering both eth-lightwallet and hooked-web3-provider (and ethjs-provider-signer for that matter) depend on 0.20 or lower.

Any suggestion from your side?

@PaulLaux
Copy link
Owner

I did not try this with the wallet, but I don't think it's going to be a problem to simply update web3.js version.

web3.js requires a provider to work:

const provider = new SignerProvider(rpcAddress, {
        signTransaction: keystore.signTransaction.bind(keystore),
        accounts: (cb) => cb(null, keystore.getAddresses()),
      });

web3.setProvider(provider);

If we update web3, it will still rely on the same eth-lightwallet and ethjs-provider-signer which in turn relay internally on web3@0.20.

This is not optimal for bundle size but should work without additional changes.
Unfortunately, web3.js tend to lag behind as a dependancy of dependency on many projects.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants