Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document and/or Upgrade Node Version #218

Open
brentarias opened this issue Mar 29, 2017 · 1 comment
Open

Document and/or Upgrade Node Version #218

brentarias opened this issue Mar 29, 2017 · 1 comment

Comments

@brentarias
Copy link

brentarias commented Mar 29, 2017

I'm using node version 7.7.4 (x64) on windows. I tried cloning NG6-starter and installing (from JSPM branch), but I'm getting gyp compilation errors. Based on posts like this or that, I think I need to downgrade the version of node I'm using.

Could you change the README to indicate what version-range of Node is valid? Also, would it make sense to upgrade package.json dependencies so that the latest node could be used?

For context, here are some of the errors I received during npm i:

npm WARN deprecated node-uuid@1.4.8: Use uuid module instead
npm WARN deprecated minimatch@2.0.10: Please update to minimatch 3.0.2 or higher to avoid a RegExp DoS issue
npm WARN deprecated minimatch@0.2.14: Please update to minimatch 3.0.2 or higher to avoid a RegExp DoS issue
npm WARN deprecated graceful-fs@1.2.3: graceful-fs v3.0.0 and before will fail on node releases >= v7.0. Please update to graceful-fs@^4.0.0 as soon as possible. Use 'npm ls graceful-fs' to find it in the tree.
npm WARN deprecated minimatch@0.3.0: Please update to minimatch 3.0.2 or higher to avoid a RegExp DoS issue
npm WARN deprecated lodash@1.0.2: lodash@<3.0.0 is no longer maintained. Upgrade to lodash@^4.0.0.

And...

> ws@0.4.32 install C:\repos\angular\NG6-starter\node_modules\karma\node_modules\ws
> (node-gyp rebuild 2> builderror.log) || (exit 0)


C:\repos\angular\NG6-starter\node_modules\karma\node_modules\ws>if not defined npm_config_node_gyp (node "C:\Program Files\nodejs\node_modules\npm\bin\node-gyp-bin\\..\..\node_modules\node-gyp\bin\node-gyp.js" rebuild )  else (node "" rebuild )
Building the projects in this solution one at a time. To enable parallel build, please add the "/m" switch.
  bufferutil.cc
  win_delay_load_hook.cc
C:\repos\angular\NG6-starter\node_modules\nan\nan.h(400): warning C4996: 'v8::ScriptCompiler::CompileUnbound': was declared deprecated (compiling source file ..\src\bufferutil.cc) [C:\repos\angular\NG6-starter\node_modules\karma\node_modules\ws\build\bufferutil.vcxproj]
  C:\Users\baria\.node-gyp\7.7.4\include\node\v8.h(1358): note: see declaration of 'v8::ScriptCompiler::CompileUnbound' (compiling source file ..\src\bufferutil.cc)
C:\repos\angular\NG6-starter\node_modules\nan\nan.h(405): warning C4996: 'v8::String::NewExternal': was declared deprecated (compiling source file ..\src\bufferutil.cc) [C:\repos\angular\NG6-starter\node_modules\karma\node_modules\ws\build\bufferutil.vcxproj]
  C:\Users\baria\.node-gyp\7.7.4\include\node\v8.h(2583): note: see declaration of 'v8::String::NewExternal' (compiling source file ..\src\bufferutil.cc)
C:\repos\angular\NG6-starter\node_modules\nan\nan.h(409): error C2039: 'ExternalAsciiStringResource': is not a member of 'v8::String' (compiling source file ..\src\bufferutil.cc) [C:\repos\angular\NG6-starter\node_modules\karma\node_modules\ws\build\bufferutil.vcxproj]
  C:\Users\baria\.node-gyp\7.7.4\include\node\v8.h(2320): note: see declaration of 'v8::String' (compiling source file ..\src\bufferutil.cc)
C:\repos\angular\NG6-starter\node_modules\nan\nan.h(409): error C2065: 'ExternalAsciiStringResource': undeclared identifier (compiling source file ..\src\bufferutil.cc) [C:\repos\angular\NG6-starter\node_modules\karma\node_modules\ws\build\bufferutil.vcxproj]
C:\repos\angular\NG6-starter\node_modules\nan\nan.h(409): error C2065: 'resource': undeclared identifier (compiling source file ..\src\bufferutil.cc) [C:\repos\angular\NG6-starter\node_modules\karma\node_modules\ws\build\bufferutil.vcxproj]
C:\repos\angular\NG6-starter\node_modules\nan\nan.h(409): error C2433: 'NanNew': '__forceinline' not permitted on data declarations (compiling source file ..\src\bufferutil.cc) [C:\repos\angular\NG6-starter\node_modules\karma\node_modules\ws\build\bufferutil.vcxproj]
C:\repos\angular\NG6-starter\node_modules\nan\nan.h(409): error C2365: 'NanNew': redefinition; previous definition was 'function' (compiling source file ..\src\bufferutil.cc) [C:\repos\angular\NG6-starter\node_modules\karma\node_modules\ws\build\bufferutil.vcxproj]
C:\repos\angular\NG6-starter\node_modules\nan\nan.h(409): error C2448: 'NanNew': function-style initializer appears to be a function definition (compiling source file ..\src\bufferutil.cc) [C:\repos\angular\NG6-starter\node_modules\karma\node_modules\ws\build\bufferutil.vcxproj]
C:\repos\angular\NG6-starter\node_modules\nan\nan.h(415): warning C4996: 'v8::BooleanObject::New': was declared deprecated (compiling source file ..\src\bufferutil.cc) 

The install then finished with this:

npm WARN karma-chai@0.1.0 requires a peer of chai@* but none was installed.
npm WARN karma-mocha@0.1.10 requires a peer of mocha@* but none was installed.
npm WARN angular-jspm-starter@0.0.1 No repository field.
@fesor
Copy link
Collaborator

fesor commented Jul 8, 2017

This repository should work with npm v3+.

No repository field.

this should be part of your project.

as for peer dependencies and deprecations, this should be fixed since this may affect users which is using npm v4+

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants