Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

transform-runtime vs babel-polyfill #184

Open
jsvg opened this issue Nov 3, 2016 · 2 comments
Open

transform-runtime vs babel-polyfill #184

jsvg opened this issue Nov 3, 2016 · 2 comments

Comments

@jsvg
Copy link

jsvg commented Nov 3, 2016

I believe these two configurations of babel are redundant.

babel-polyfill provides globals for es6 features, while the runtime transform method polyfills without using global methods. The latter method is usually preferable.

Would suggest modifying package.json to remove babel-polyfill. Also, babel docs recommend babel-runtime be included as a dependency (not devDep). Then babel-polyfill can be removed from the gulp file's paths.entry array.

This change appears to reduce build size by a small amount.

Can PR this if desired.

@JabbyPanda
Copy link

Actually, babel docs recommend to include babel-runtime as development dependency (devDep)

http://babeljs.io/docs/plugins/transform-runtime/#installation

@soda-x
Copy link

soda-x commented May 22, 2017

@JabbyPanda
babel-runtime should be included as a dependency (not devDep) and babel-plugin-transform-runtime should be included as a dev-dependency.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants