Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should unit ctypes be shipped with our project for Delphi users? #67

Open
Free-Pascal-meets-SDL-Website opened this issue Jul 11, 2022 · 0 comments
Labels
discussion Discuss an idea/feature/PR/issue...

Comments

@Free-Pascal-meets-SDL-Website
Copy link
Collaborator

At the moment we have this file ctypes.inc to map native c data types for Delphi users. Would it be better to ship the ctypes unit from FPC along with our project?

Advantage

  • we do not need to maintain a separate file ourselves
  • both compilers have the same condition: on the same system, the mapping will be the same
  • many different systems would get the correct C types mapping (our ctypes.inc is very, very basic)
  • we don't need to IFDEF the ctypes unit anymore

Disadvantage

  • not sure about the compatibility of the ctypes unit with Delphi (there are delphi conditionals within the file, but are they meant for Delphi or FPC's Delphi mode?)
  • Not sure about the licensing, can our MPL-zlib dual license still apply if we ship the unit along with our project? (If not, case is closed, we can not do it.)
  • We need to make sure to keep the most recent version of the ctypes unit (but it seems, it is updated very, very rarely)

Best regards

Edit: Correct typo in license abbreviation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
discussion Discuss an idea/feature/PR/issue...
Projects
None yet
Development

No branches or pull requests

1 participant