Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add processing times to OpenTelemetry metrics #6868

Open
timbussmann opened this issue Sep 26, 2023 · 4 comments
Open

Add processing times to OpenTelemetry metrics #6868

timbussmann opened this issue Sep 26, 2023 · 4 comments

Comments

@timbussmann
Copy link
Contributor

Describe the suggested improvement

The NServiceBus OpenTelemetry integration currently promotes the following metrics:

  • nservicebus.messaging.successes: Total number of messages processed successfully by the endpoint
  • nservicebus.messaging.fetches: Total number of messages fetched from the queue by the endpoint
  • nservicebus.messaging.failures: Total number of messages processed unsuccessfully by the endpoint

The NServiceBus.Metrics package supports more metrics though, for example

These metrics are currently not available when using the OpenTelemetry integration instead of the Metrics package. When using OpenTelemetry, it does only add noise and overhead to also rely on the NServiceBus.Metrics package for these additional metrics.

Describe the suggested solution

Add additional metrics to the built-in OpenTelemetry metrics, e.g. Critical time and processing time.

Additional Context

No response

@cjoergensen
Copy link

Does the NServiceBus.Metrics package expose the metrics via OpenTelemetry by default, or does it require custom code?

@mauroservienti
Copy link
Member

@cjoergensen, the Metrics package was designed before the advent of OTel. It requires custom code to capture and report those metrics to an OpenTelemetry collector. I'm not sure the data exposed by the Metrics package have all the needed information to plugin into the OTel activities model.

More details in our documentation.

@bbrandt
Copy link

bbrandt commented Feb 10, 2024

FYI, stay tuned! Great things are on the way according to David Boike!

Particular/docs.particular.net#6446 (comment)

@bbrandt
Copy link

bbrandt commented Apr 25, 2024

Workaround to get these metrics in App Insights without the need for NServiceBus.Metrics:
https://docs.particular.net/samples/open-telemetry/application-insights/

And Prometheus:
https://docs.particular.net/samples/open-telemetry/prometheus-grafana/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants