You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Currently there are a few operations that take a performance hit that is noticeable due to brief UI lockups, these mostly occur when the comment section is loading, which can contain a significant amount of data, and deep hierarchy.
In multiple sections of the extension the root path is being passed arbitrarily, meaning the recursive function has to traverse the entire json tree even when it might not be of interest for the function using it.
Ideally this should be substituted by a specific prior root path check to ensure the data is of interest of the function, for example:
Problem is this might introduce bugs because there might be multiple paths for the same root and all must be covered, for example a multi-path deep node:
Issue seems more evident when the user is logged in, especially when loading the comment section. If the user is not logged in, there are no performance issues. This indicates that the comment payloads when logged in are significantly bigger.
The difference in seconds for processing the comment section payload when not logged in vs logged in is respectively 0.102s and 3.2s (according to a few random tests).
Things have been busy lately, and I have yet to find a good way to go about this so I will likely compromise on just excluding any results that are related to the comment section for now and think of a different way to go about it in the future.
Currently there are a few operations that take a performance hit that is noticeable due to brief UI lockups, these mostly occur when the comment section is loading, which can contain a significant amount of data, and deep hierarchy.
In multiple sections of the extension the root path is being passed arbitrarily, meaning the recursive function has to traverse the entire json tree even when it might not be of interest for the function using it.
Ideally this should be substituted by a specific prior root path check to ensure the data is of interest of the function, for example:
Iridium/src/firefox/js/background-inject.js
Lines 254 to 259 in a5b58a3
Problem is this might introduce bugs because there might be multiple paths for the same root and all must be covered, for example a multi-path deep node:
Iridium/src/firefox/js/background-inject.js
Lines 2707 to 2708 in a5b58a3
However, the performance impact is noticeable so this must be improved in one way or another.
The text was updated successfully, but these errors were encountered: