Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug in Knockoffs data generation #13

Open
alexblnn opened this issue Sep 21, 2022 · 1 comment
Open

Bug in Knockoffs data generation #13

alexblnn opened this issue Sep 21, 2022 · 1 comment

Comments

@alexblnn
Copy link
Collaborator

In data simulation sampling should be without replacement, so that a single variable can only be selected once. Else False Discovery Proportion and power are not correctly computed in experiments.
@tbng tbng mentioned this issue Sep 28, 2022
Open
@tbng
Copy link
Collaborator

tbng commented Sep 28, 2022

Good catch ! I created PR #14 for this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@tbng @alexblnn