Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug: processRecurrence is slow #9722

Open
Dschoordsch opened this issue May 7, 2024 · 2 comments
Open

Bug: processRecurrence is slow #9722

Dschoordsch opened this issue May 7, 2024 · 2 comments
Labels
bug p2 Needs to be addressed on a reasonable timescale

Comments

@Dschoordsch
Copy link
Contributor

Dschoordsch commented May 7, 2024 •
edited

The mutation takes >15s, see logs 馃敀 We only run it every 5min so it's not an issue at the moment, but it should be faster.
Also testing processRecurrence times out sometimes https://github.com/ParabolInc/parabol/actions/runs/8982173873/job/24669192689?pr=9720
@Dschoordsch Dschoordsch added bug p2 Needs to be addressed on a reasonable timescale labels May 7, 2024
This was referenced May 7, 2024
Merged
Merged
Merged
@Dschoordsch
Copy link
Contributor Author

RRule.between is the slow part, see traces 馃敀

@Dschoordsch
Copy link
Contributor Author

The slowness comes from the time zone processing https://github.com/jkbrzt/rrule/blob/9f2061febeeb363d03352efe33d30c33073a0242/src/datewithzone.ts#L32
When processing all RRules locally (~1100) takes 18s with tzid and only 1s when stripping tzid.
Also RRules need to always iterrate from the start to the current between args, so it will only get worse over time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug p2 Needs to be addressed on a reasonable timescale
Projects
Product
Status: To triage
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Dschoordsch