Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inline pictures in emails to avoid expiring presigned URLs #9700

Open
3 tasks
mattkrick opened this issue May 1, 2024 · 1 comment
Open
3 tasks

Inline pictures in emails to avoid expiring presigned URLs #9700

mattkrick opened this issue May 1, 2024 · 1 comment
Labels
enhancement Platform One Items that _must_ be addressed for Platform One

Comments

@mattkrick
Copy link
Member

As we move towards requiring presigned URLs for UGC like avatars, if we use those links in emails then pictures in emails will fail to load after the URL expires.

To avoid this, we should try inlined attachments. We tried this once before, but perhaps we used non-inline attachments?
#2527 (comment)

AC

  • pictures in emails are self-contained in the email & do not require accessing a CDN
  • the size of the email isn't so big that it sometimes bounces (base64 inlining can do this)
  • pictures don't show up as downloadable attachments
@mattkrick mattkrick added the Platform One Items that _must_ be addressed for Platform One label May 1, 2024
@jordanh
Copy link
Contributor

jordanh commented May 20, 2024

scrubbed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Platform One Items that _must_ be addressed for Platform One
Projects
Status: To triage
Development

No branches or pull requests

2 participants