chore: migrate EmailVerification to pg #9492
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sasha fell asleep early, and I felt itchy |
jordanh
commented
Mar 2, 2024
| @@ -55,9 +57,9 @@ const signUpVerified = async (email: string) => { | |||
| expect(verifyEmail).toMatchObject({ | |||
| data: { | |||
| verifyEmail: { | |||
| authToken: expect.toBeString(), | |||
There was a problem hiding this comment.
I was getting TS failures here
jordanh
commented
Mar 2, 2024
| @@ -153,7 +155,7 @@ test.skip('autoJoin on multiple teams does not create duplicate `OrganizationUse | |||
| const newEmail = `${faker.internet.userName()}@${domain}`.toLowerCase() | |||
| const {user: newUser} = await signUpVerified(newEmail) | |||
|
|
|||
| expect(newUser.tms).toIncludeSameMembers(teamIds) | |||
| expect(newUser.tms).toEqual(expect.arrayContaining(teamIds)) | |||
jordanh
commented
Mar 2, 2024
| @@ -12,16 +10,14 @@ interface Input { | |||
| } | |||
|
|
|||
| export default class EmailVerification { | |||
| id: string | |||
There was a problem hiding this comment.
Once again, id is now managed by PG
jordanh
force-pushed
the
chore/9491/migrate-emailverification
branch
from
d67de35
to
98755f9
Compare
mattkrick
approved these changes
Mar 5, 2024
| .selectAll() | ||
| .where('email', '=', email) | ||
| .where('expiration', '>', new Date()) | ||
| .executeTakeFirst()) || null |
There was a problem hiding this comment.
+1 no need to coerce to null since kysely will return undefined which works just as well in this case
| .selectFrom('EmailVerification') | ||
| .selectAll() | ||
| .where('token', '=', verificationToken) | ||
| .executeTakeFirst()) as EmailVerification) || null |
There was a problem hiding this comment.
+1 no need to coerce to EmailVerification || null since kysely knows the return type
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Resolves #9491
Testing scenarios
Migrations
EmailVerificationon pgCan verify email address with token
Final checklist