Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prompt to join org does not work with SSO #9411

Open
igorlesnenko opened this issue Feb 7, 2024 · 5 comments · May be fixed by #9429
Open

Prompt to join org does not work with SSO #9411

igorlesnenko opened this issue Feb 7, 2024 · 5 comments · May be fixed by #9429
Labels
bug p2 Needs to be addressed on a reasonable timescale

Comments

@igorlesnenko
Copy link
Contributor

igorlesnenko commented Feb 7, 2024

  • Now we require email to be verified to use prompt to join org
  • For loginWithSAML we don't create identities array, which we use to determine if email is verified
  • This cause a bug

Solutions:

@igorlesnenko igorlesnenko added bug p2 Needs to be addressed on a reasonable timescale labels Feb 7, 2024
@igorlesnenko igorlesnenko self-assigned this Feb 7, 2024
@igorlesnenko
Copy link
Contributor Author

No, quick solution is not very good, we checking identities several times in nested prompt to join functions.

@Dschoordsch
Copy link
Contributor

I propose the quickfix:

@igorlesnenko
Copy link
Contributor Author

We have many loops where isUserVerified is called. I'm worrying that it is async and it may accidentally cause a lot of queries. Let me check, I feel that the right way to fix it would be not much complex

@igorlesnenko
Copy link
Contributor Author

I started with identities solution, but it feels more tricky, will link my draft PR and will do a quick one.
#9420

@igorlesnenko igorlesnenko linked a pull request Feb 15, 2024 that will close this issue
@jordanh
Copy link
Contributor

jordanh commented Mar 15, 2024

This would be good for us to fix finish fixing up. I'll add it near the top of our queue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug p2 Needs to be addressed on a reasonable timescale
Projects
Status: No status
Status: In progress
Development

Successfully merging a pull request may close this issue.

3 participants