Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rcon-cli broken #170

Open
Alestrix opened this issue Nov 25, 2023 · 9 comments
Open

rcon-cli broken #170

Alestrix opened this issue Nov 25, 2023 · 9 comments
Labels
status: needs triage type: bug Something doesn't work as it was intended to. version: 1.20.2 Game version 1.20.2

Comments

@Alestrix
Copy link

Alestrix commented Nov 25, 2023

Expected behavior

docker exec -ti mc rcon-cli list should run the /list command on the console

Observed/Actual behavior

$ docker exec -ti mc rcon-cli list
Error executing: list (null)

Steps/models to reproduce

Run itzg/minecraft-server:latest image with TYPE: FOLIA as environment, wait for the server to come up and execute above command.

Plugin and Datapack List

No plugins or datapacks. Executing listed commands not possible due to bug mentioned in this report.

Folia version

According to docker logs mc:

...
[mc-image-helper] 00:59:22.273 INFO  : Resolved folia to version 1.20.2 build 18
[mc-image-helper] 00:59:25.018 INFO  : Downloaded /data/folia-1.20.2-18.jar
...

Other

I double-checked with the maintainer of itzg/minecraft-server and they confirm that this is a Folia issue.

@Alestrix Alestrix added status: needs triage type: bug Something doesn't work as it was intended to. labels Nov 25, 2023
@ocelotpotpie
Copy link

rcon functionality is not currently planned for Folia. That may change in the future but for now this is as expected.

@ocelotpotpie ocelotpotpie closed this as not planned Won't fix, can't repro, duplicate, stale Nov 25, 2023
@Alestrix
Copy link
Author

Alestrix commented Nov 25, 2023

Thanks @ocelotpotpie for the quick reply! Is this documented anywhere and does the regular paper release support rcon?

@Spottedleaf
Copy link
Member

1e5e215 May resolve the issue, can you re-test?

@Spottedleaf Spottedleaf reopened this Nov 25, 2023
@fisher60
Copy link

fisher60 commented Dec 17, 2023

Hello, I see that rcon support is marked as not planned. I have only recently started playing with folia, but the lack of rcon immediately makes folia unusable for my regular needs when hosting an MC server.

Especially considering Folia is intended as a higher performance implementation, remote server management seems it would be essential.

Also worth mentioning, the linked fix seems to fix the error messages received in version 1.20.2, but the command executions do not appear to have any effect on my machine (when running rcon-cli in docker)

@Spottedleaf
Copy link
Member

Spottedleaf commented Dec 22, 2023

A lot of commands schedule now onto different contexts, which means when the command finishes synchronously it may not have the resulting command response available - as it has not actually finished execution.
This is a more general problem with the command system, as there is no way to signal an asynchronous completion.

Not sure what I can do to fix that, as it's always been an issue with RCON but it's certainly more noticeable now.

@electronicboy
Copy link
Member

I recall lucko created a PR to spigot years ago to try to add a means to control buffering and releasing the rcon response, it is something I've wanted to look into for paper, just, rcon is not something that deems any priority

@Netherwhal
Copy link

I think even if we had a "fire and forget" option that would be great, as already mentioned, even today with Paper you can not really rely on RCON anymore for request<>response operations, but it is useful to send commands. We usually then read the results from the DB (most plugins will write to the db, but they do not action of 3rd party writes to the db)

@Spottedleaf
Copy link
Member

2756175 Is another fix for RCON

@Netherwhal
Copy link

This can be closed - and rather create specific ticket? To me I see no difference in usage to Paper: it works "as expected" (e.g. those async issues also exist in paper).

@kashike kashike added the version: 1.20.2 Game version 1.20.2 label Apr 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: needs triage type: bug Something doesn't work as it was intended to. version: 1.20.2 Game version 1.20.2
Projects
None yet
Development

No branches or pull requests

7 participants