Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] WordType.word() not compatible with non-ASCII characters #425

Closed
File14 opened this issue Nov 22, 2022 · 5 comments
Closed

[BUG] WordType.word() not compatible with non-ASCII characters #425

File14 opened this issue Nov 22, 2022 · 5 comments
Labels

Comments

@File14
Copy link

File14 commented Nov 22, 2022

Describe the bug
Non-ASCII commands are no longer working after the 1.19 commits. For example, the Swedish letters "å", "ä", and "ö" are no longer working with the WordType.word() argument type.

To Reproduce
Steps to reproduce the behavior:

  1. Type a command containing a letter such as "ö" (WordType.word()).
  2. Screenshot of the error.

Expected behavior
The command should be executed as usual since it is supported by greedy strings.
See code here.

Environment (please complete the following information):

  • Java Version [17]
  • Platform [PaperMC]
  • Platform Version [1.19.2]
  • Chimera Version [5.4.2]
@File14 File14 added the bug label Nov 22, 2022
@Pante
Copy link
Owner

Pante commented Nov 22, 2022

Hey there, thanks for reporting the issue. This seems like an interesting one. Only executing a command with non-ASCII charterers in-game causes an issue. Executing the same command from console seems to work fine. This probably indicates that Paper/Spigot internally changed some command-related stuff.

By any chance, do you know which build your plugin was last working and/or which build your plugin started to fail?

@Pante
Copy link
Owner

Pante commented Nov 23, 2022

After further investigation, this issue is linked to how only commands issued by players are routed to directly to the native CommandDispatcher in 1.19.

@Pante
Copy link
Owner

Pante commented Nov 23, 2022

Looking into the issue, I don't think it's possible to continue supporting non-ASCII characters the way we do, it's just impossible with the changes made to Spigot in 1.19. I'll try to see if Spigot is willing to accept a patch that will resolve this issue, but no guarantees. In the worst case scenario, WordType.word() will no longer be supported.

See https://hub.spigotmc.org/jira/browse/SPIGOT-7187 for more updates.

@Pante
Copy link
Owner

Pante commented Dec 22, 2022

Seeing that there hasn't been any progress on that issue, WordType.word() will probably be deprecated. Recent changes to Spigot simply makes it impossible to do so.

@Pante
Copy link
Owner

Pante commented Mar 12, 2023

WordType.word() is now deprecated for removal in 5.5.0

@Pante Pante closed this as completed Mar 12, 2023
@Pante Pante pinned this issue Mar 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants