Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

API call made on show params #798

Open
Pratosh22 opened this issue Apr 10, 2024 · 3 comments
Open

API call made on show params #798

Pratosh22 opened this issue Apr 10, 2024 · 3 comments
Assignees
Labels
bug Something isn't working

Comments

@Pratosh22
Copy link

Describe the bug

When show optional parameters is clicked on request form, it makes an API call, which is not expected.

Expected behavior

API call should not be made, it should be made only on pressing the SEND API BUTTON

Current behavior

API call made on clicking show optional params

Possible solution

Set Response action is dispatched, which should ideally not be dispatched in this case

Screenshots

Screen.Recording.2024-04-11.at.1.10.28.AM.mov

Your Environment

  • Version used: 2.1.3
  • Operating System and version (desktop or mobile):MacOS
@Pratosh22 Pratosh22 added the bug Something isn't working label Apr 10, 2024
@sserrata
Copy link
Member

@blindaa121 seems similar to #796, any idea why we're just noticing this issue? Is it reproducible on pan.dev?

@blindaa121
Copy link
Collaborator

blindaa121 commented Apr 12, 2024

@sserrata Hmm.. yeah let me look into this one. Issue is reproducible on pan.dev as well

@stakoov
Copy link
Contributor

stakoov commented Apr 16, 2024

Hi @sserrata @blindaa121 the issue here is that this button are in form tag and their default types are type="submit". We need to check and change them to type="button" or remove the form tag :).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants