How to avoid GitHub test failures?

[martinholmer]

Related to issue #53.

[nikhilwoodruff]

@martinholmer- you'll need to file pull requests from branches on the repo rather than forks (otherwise, anyone could obtain the PUF by forking the repo). Sorry for not mentioning this- I'll add this to the README.

[martinholmer]

@nikhilwoodruff said in issue #56:

you'll need to file pull requests from branches on the repo rather than forks

Thanks for the tip, but I have no idea how to do that. Can you provide more details?

[MaxGhenis]

As an example, you'd clone https://github.com/PSLmodels/tax-microdata-benchmarking instead of https://github.com/martinholmer/tax-microdata-benchmarking

[martinholmer]

@MaxGhenis said in issue #56:

As an example, you'd clone https://github.com/PSLmodels/tax-microdata-benchmarking instead of https://github.com/martinholmer/tax-microdata-benchmarking

If I can do that, what prevents anybody else from doing that, and therefore, getting access to the private PUF data? What am I missing?

[MaxGhenis]

Only people with write access to a repo can push a PR from it without using a fork, since it involves creating a branch from the main repo (rather than a branch from one's fork).

[martinholmer]

@MaxGhenis said in issue #56:

Only people with write access to a repo can push a PR from it without using a fork, since it involves creating a branch from the main repo (rather than a branch from one's fork).

OK. What steps do I need to take to get rid of https://github.com/martinholmer/tax-microdata-benchmarking before cloning https://github.com/PSLmodels/tax-microdata-benchmarking on my computer?

[MaxGhenis]

You could do something like the reverse of this: https://stackoverflow.com/a/33817239/1840471

Or simpler could be just creating a new folder on your computer and cloning into there. You don't need to remove the clone of your fork.

[martinholmer]

@nikhilwoodruff and @MaxGhenis,
Following Max's suggestion, I cloned this PSLmodels GitHub repository directly to my computer. Then I created PR #75 containing a one-word change to the README.md file. But the tests on GitHub still failed. Here is the error that caused the test failure:

========================= short test summary info ==========================
FAILED tests/test_flat_file.py::test_2021_flat_file_builds - 
ValueError: Invalid response code 401 for url 

https://api.github.com/repos/policyengine/policyengine-us/
   releases/tags/enhanced-cps-2022

What did I do wrong?

[martinholmer]

Worked after TOKEN was undated on GitHub.
@MaxGhenis and @nikhilwoodruff, Thanks for the help on this.