Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate add_weighted_quantiles #185

Open
MaxGhenis opened this issue Feb 25, 2021 · 0 comments
Open

Deprecate add_weighted_quantiles #185

MaxGhenis opened this issue Feb 25, 2021 · 0 comments

Comments

@MaxGhenis
Copy link
Collaborator

MaxGhenis commented Feb 25, 2021

It doesn't work with MicroDataFrames (weights by the weight squared if the weight column is in the DataFrame):

df[col_pctile] = 100 * df[w].cumsum() / df[w].sum()

It also sorts the data which can create issues, and it creates tons of columns when usually a user just wants one at a time. These could be overcome but I think it'd be better to invest in MicroDataFrame.rank and MicroSeries.rank (#187).

@MaxGhenis MaxGhenis changed the title Make add_weighted_quantiles work with MicroDataFrames Deprecate add_weighted_quantiles Feb 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant