Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename SS_thd50 and SS_thd85 to SS_thd1 and SS_thd2 #2595

Open
MaxGhenis opened this issue May 31, 2021 · 2 comments
Open

Rename SS_thd50 and SS_thd85 to SS_thd1 and SS_thd2 #2595

MaxGhenis opened this issue May 31, 2021 · 2 comments
Labels
backward-incompatible Changes proposed in this PR/Issue are not backwards compatible good first issue Good issues for a person new to this project help wanted

Comments

@MaxGhenis
Copy link
Contributor

MaxGhenis commented May 31, 2021 •
edited

I think SS_thd50 and SS_thd85 are the only policy parameters with their default values in their name. This also diverges from SS_percentage1 and SS_percentage2 which are set to 0.5 and 0.85, respectively. Renaming the thresholds to SS_thd1 and SS_thd2 would be more consistent.

The variable descriptions also specify 50% and 85% in them, unlike other thresholds.
@MaxGhenis MaxGhenis mentioned this issue May 31, 2021
Merged
@jdebacker jdebacker added the backward-incompatible Changes proposed in this PR/Issue are not backwards compatible label Jul 20, 2021
@jdebacker jdebacker added good first issue Good issues for a person new to this project help wanted Hacktoberfest Highlighting good issues for Hacktoberfest labels Sep 27, 2021
@TishaJhabak1014
Copy link

@jdebacker Is this issue solved??

@jdebacker
Copy link
Member

jdebacker commented Oct 2, 2021 •
edited

@TishaJhabak1014 This issue is still open. It will make a change that is backwards incompatible. I've created a new v4_development branch to merge the changes related to this issue into whenever someone decides to tackle it.

@jdebacker jdebacker removed the Hacktoberfest Highlighting good issues for Hacktoberfest label Nov 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
backward-incompatible Changes proposed in this PR/Issue are not backwards compatible good first issue Good issues for a person new to this project help wanted
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@MaxGhenis @jdebacker @TishaJhabak1014