Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apple status "complete" before episode publishes #995

Open
cavis opened this issue Apr 15, 2024 · 1 comment · May be fixed by #1010
Open

Apple status "complete" before episode publishes #995

cavis opened this issue Apr 15, 2024 · 1 comment · May be fixed by #1010
Assignees
Labels

Comments

@cavis
Copy link
Member

cavis commented Apr 15, 2024

Doing some QA-ing last week in staging, I noticed that the "complete" badge was showing up 15+ minutes before the episode successfully pushed to Apple (looking at the publishing pipeline state).

@kookster kookster self-assigned this Apr 22, 2024
@svevang
Copy link
Member

svevang commented Apr 22, 2024

Take a look here:
https://github.com/PRX/feeder.prx.org/blob/main/app/models/apple/episode.rb#L499-L511

The derived statues used here partially come from the delivery status model. Though the apple delivery status model solely deals with the "upload and moving of files" aspect. The top level concerns dealing with "is this episode synced?" are all on the episode model. These methods don't hit the APIs

@kookster kookster linked a pull request Apr 29, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants