New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Inconsistent unit (rad vs deg) in c++ and python #339

Closed

wing-kit opened this issue May 9, 2024 · 1 comment

wing-kit commented May 9, 2024

https://github.com/PRBonn/kiss-icp/blob/main/cpp/kiss_icp/metrics/Metrics.cpp#L152
In the implementation part it is in rad/m.

https://github.com/PRBonn/kiss-icp/blob/main/python/kiss_icp/metrics.py#L30

In the rendering it says it is in deg/m.
https://github.com/PRBonn/kiss-icp/blob/main/python/kiss_icp/pipeline.py#L175

wing-kit added a commit to wing-kit/kiss-icp that referenced this issue


          from deg/m to rad/m

f1c1af3

PRBonn#339

wing-kit mentioned this issue

from deg/m to rad/m #340

Closed

benemer closed this as completed

Member

benemer commented May 19, 2024

See #340

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment