Fix points_to_spheres bug in 3D
#932
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ma-sadeghi
changed the title
points_to_spheres bug in 3D
ma-sadeghi
requested changes
Mar 13, 2024
… im is still NOT TESTED !
|
I added a simple test case for 2D and 3D. I did not add anything for im being a boolean array, since I do not really know what the expected output would be. It feels broken, but I do not know for sure. |
That seems strange, I can't look at it right now, but will do later this week. |
|
Is this PR still considered or is it outdated now? |
|
Sorry for the delay. I still didn't get the chance to review it. Will do this week hopefully. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #917