Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

network_from_porespy should fix coords #2639

Open
jgostick opened this issue Dec 9, 2022 · 1 comment
Open

network_from_porespy should fix coords #2639

jgostick opened this issue Dec 9, 2022 · 1 comment
Assignees
@Ni2M

Comments

@jgostick
Copy link
Member

jgostick commented Dec 9, 2022

This has always been so annoying. In 2d you have to swap x and y coords. The import function should just do it.
@ma-sadeghi ma-sadeghi changed the title network_from_porespy should fix coords network_from_porespy should fix coords Dec 12, 2022
@jgostick jgostick mentioned this issue Jan 8, 2023
Open
@Ni2M Ni2M self-assigned this Jan 19, 2023
@jgostick
Copy link
Member Author

Actually, the to_vtk function in porespy.io does NOT cause any problems, so if we change the way openpnm deals with coords, then we'll break the to_vtk. to_vtk is actually better than reading a tiff image since it does not interpolate pixels, so single-pixel thick things are visible.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Ni2M Ni2M

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jgostick @Ni2M