Throats from face pore body to face pore body for FaceCenteredCubic

[AnnaMareike]

Hi all,

If I use op.network.FaceCenteredCubic(...) to create a network, throats which are connected to two pore bodies at a face are currently labeled with corner_to_face.

Shouldn't they be labeled as face_to_face? (For BodyCenteredCubic respective throats also get labeled body_to_body.)

I'm just wondering if this is a bug, which needs to be fixed or if this is on purpose and I should relabel the respective throats if I want them to be labeled as face_to_face.

Plots for understanding
This is the plot created for the FaceCenteredCubic , where also corner_to_face (red) throats can be found between two face (green)pore bodies. This seems wrong in my opinion.

BodyCenteredCubic : Here body_to_body (green) throats can be correctly found between two body (green) pore bodies

Code to reproduce plots

import openpnm as op
import matplotlib.pyplot as plt

network_fcc = op.network.FaceCenteredCubic(shape=[3, 2, 2])
network_bcc = op.network.BodyCenteredCubic(shape=[3, 2, 2])

pores_corner_fcc = network_fcc['pore.corner']
pores_face_fcc = network_fcc['pore.face']
throats_corner_to_face_fcc = network_fcc['throat.corner_to_face']
throats_corner_to_corner_fcc = network_fcc['throat.corner_to_corner']

pores_corner_bcc = network_bcc['pore.corner']
pores_body_bcc = network_bcc['pore.body']
throats_corner_to_body_bcc = network_bcc['throat.corner_to_body']
throats_corner_to_corner_bcc = network_bcc['throat.corner_to_corner']
throats_body_to_body_bcc = network_bcc['throat.body_to_body']


plot_network = True

if plot_network:
    ax1 = op.visualization.plot_connections(network_fcc, throats=throats_corner_to_face_fcc, color = 'r', label = 'corner_to_face throat')
    ax1 = op.visualization.plot_connections(network_fcc, ax=ax1, throats=throats_corner_to_corner_fcc, color = 'b' , label = 'corner_to_corner throat')
    ax1 = op.visualization.plot_coordinates(network_fcc, ax=ax1, pores=pores_corner_fcc, c='b', label = 'corner pore body')
    ax1 = op.visualization.plot_coordinates(network_fcc, ax=ax1, pores=pores_face_fcc, c='g', label = 'face pore body')
    plt.legend()
    plt.show()

    ax2 = op.visualization.plot_connections(network_bcc, throats=throats_corner_to_body_bcc , color = 'r', label = 'corner_to_body throat')
    ax2 = op.visualization.plot_connections(network_bcc, ax=ax2, throats=throats_corner_to_corner_bcc, color = 'b' , label = 'corner_to_corner throat')
    ax2 = op.visualization.plot_connections(network_bcc, ax=ax2, throats=throats_body_to_body_bcc, color = 'g' , label = 'body_to_body throat')
    ax2 = op.visualization.plot_coordinates(network_bcc, ax=ax2, pores=pores_corner_bcc, c='b', label = 'corner pore body')
    ax2 = op.visualization.plot_coordinates(network_bcc, ax=ax2, pores=pores_body_bcc, c='g', label = 'body pore body')
    plt.legend()
    plt.show()

[jgostick]

I think you are correct that this is a bug. Nice catch. I will convert this to an issue.

[AnnaMareike]

Perfect, thanks!