Skip to content

Latest commit

 

History

History
50 lines (30 loc) · 3.57 KB

CONTRIBUTING.md

File metadata and controls

50 lines (30 loc) · 3.57 KB

Contributing to BEaTmap

BEaTmap is a tool for BET surface area analysis from adsorption data. We hope other researchers will also find it useful, and ultimately hope users will contribute their own functions to the package to help make it even more useful. This guide is intended to make it as easy as possible to get involved.

Before you start you'll need to set up a free GitHub account and sign in. Here are some instructions to get started.

Ways to Contribute

Open a New Issue

We use Github to track issues. Issues can take the form of:

(a) bug reports such as a function producing an error or odd result in some circumstances.

(b) feature requests such a suggesting a new function be added to the package, presumably based on some literature report that describes it, or enhancements to an existing function.

(c) general usage questions where the documentation is not clear and you need help getting a function to work as desired. This is actually a bug report in disguise since it means there is a problem with the documentation.

Addressing Open Issues

Help fixing open issues is always welcome; however, the learning curve for submitting new code to any repo on Github is a bit intimidating. The process is as follows:

a) Fork BEaTmap to your own Github account. This lets you work on the code since you are the owner of that forked copy.

b) Pull the code to your local machine using some Git client. We suggest GitKraken. For help using the Git version control system, see these resources.

c) Create a new branch, with a useful name like "fix_issues_011" or "add_awesome_feature", then checkout that branch.

d) Edit the code as desired, either fixing or adding something. You'll need to know Python and the various packages in the Scipy stack for this part.

e) Push the changes back to Github, to your own repo.

f) Navigate to the pull requests area on the BEaTmap repo, then click the "new pull request" button. As the name suggests, you are requesting us to pull your code in to our repo. You'll want to select the correct branch on your repo (e.g. "add_awesome_feature") and the "main" branch on BEaTmap.

g) This will trigger several things on our repo, including most importantly a conversation between you and the BEaTmap team about your code. After any fine-tuning is done, we will merge your code into BEaTmap, and your contribution will be immortalized in BEaTmap.

Adding Examples

We also have example notebook(s) included in the BEaTmap source code, all done in Jupyter notebooks. This is also an excellent place to contribute, by showing users how to reproduce some results in a published paper. The fork and pull request workflow mentioned above still applies; however, if you wish to contribute a Notebook without all the hassle, you can just email the file to one of the BEaTmap developers and we can add it to the repo for you.