Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Possibly redundant patchghost copies #816

Open
PhilipDeegan opened this issue Mar 22, 2024 · 0 comments
Open

Possibly redundant patchghost copies #816

PhilipDeegan opened this issue Mar 22, 2024 · 0 comments
Assignees
Milestone

Comments

@PhilipDeegan
Copy link
Member

Currently in both solver_ppc and Ion_Updater::updateAndDepositDomain_ we copy the patch ghosts per patch during advance.

It's possible that one of these might be redudant.

Having tried removing the copy from solver_ppc, we see test failures in test_advance::_test_L0_particle_number_conservation

with particle count mismatch,

however if we remove the copy in updater, we only see test failures in test_updater.cpp @

TYPED_TEST(IonUpdaterTest, particlesUntouchedInMomentOnlyMode)

which might just not make sense anymore

the above can be seen on my fork @ PhilipDeegan#91

@nicolasaunai nicolasaunai self-assigned this May 11, 2024
@nicolasaunai nicolasaunai added this to the 1.1 milestone May 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: thinking... 🤯
Development

No branches or pull requests

2 participants