Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

default initialize particles? #796

Open
nicolasaunai opened this issue Dec 14, 2023 · 1 comment
Open

default initialize particles? #796

nicolasaunai opened this issue Dec 14, 2023 · 1 comment
Milestone

Comments

@nicolasaunai
Copy link
Member

Should we allow for default particle init? I don't think so unless it's so much trouble not to.

@nicolasaunai nicolasaunai added this to the 1.1 milestone Dec 14, 2023
@PhilipDeegan
Copy link
Member

we have a case where we do actually use a default initialized particle for diagnostics.
I believe it's in order to forward the type to highfive to create a dataset, and the values are not "used" per se

other than that there some default initialized particles in tests

the simplest approach might be multiple classes, where the current "Particle" class becomes non-default construcbile, but it inherits from a super class "AParticle(?)" which is default constructible

or the particle class has an optional template param deciding if it's default constructible

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Do me  👋
Development

No branches or pull requests

2 participants