Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the compute_timestamps from pharein user interface #773

Open
nicolasaunai opened this issue Nov 9, 2023 · 0 comments
Open

Remove the compute_timestamps from pharein user interface #773

nicolasaunai opened this issue Nov 9, 2023 · 0 comments
Assignees
Milestone

Comments

@nicolasaunai
Copy link
Member

Currently, each Diagnostic has a compute_timestamp keyword argument that is supposed to tell PHARE how often a given diagnostics should be computed.
This comes in addition to the write_timestamps that says how often the diag should be dumped.
The idea behind the "compute" was that some diags may require computations more often than being written, like for instance a time averaged density field, could be the result of computing a running average density field every 10 simulated time steps but dumping the averaged value every 100 dt only.
However having these to timestamps set by the user require us to check they are compatible etc.

It should not be the user's problem to figure out how often a given thing should be computed, pharein should figure it out by itself given the type of the diagnostics and the write cadence.

This issue is therefore about:

  • removing compute_timetamps from the Diagnostics (and subclasses) interface
  • having diagnostics figuring out the compute cadence themselves.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Do me  👋
Development

No branches or pull requests

1 participant