Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

restarted simulation settings compatibility with original #666

Open
PhilipDeegan opened this issue Mar 4, 2022 · 5 comments
Open

restarted simulation settings compatibility with original #666

PhilipDeegan opened this issue Mar 4, 2022 · 5 comments
Assignees
Milestone

Comments

@PhilipDeegan
Copy link
Member

it's expected that some parameters would be considered invalid if they are changed between the original and the restarted simulation.
for instance, the L0 domain cells and dl

the code will reference this issue where this is to be maintained and considered.

@PhilipDeegan
Copy link
Member Author

👿

@nicolasaunai
Copy link
Member

👹

@PhilipDeegan
Copy link
Member Author

we have the serialized simulation in each diags file, so we should have some is_enough_equal ~~ rather than == to say if they are interoperable

@nicolasaunai
Copy link
Member

yeah some is_restart_compatible() that would assert key params are or not ok.

@PhilipDeegan
Copy link
Member Author

seems it was done soon after ticket creation
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: thinking... 🤯
Development

No branches or pull requests

2 participants