Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proposal for the introduction of extensions #527

Closed
wants to merge 12 commits into from
Closed

Proposal for the introduction of extensions #527

wants to merge 12 commits into from

Conversation

FFroehlich
Copy link
Collaborator

@FFroehlich FFroehlich commented Oct 20, 2021

This pull request describes a proposal for the extension of PEtab (see #528) that allows changes to the format through extensions. The proposed development and acceptance procedure is described in the changes to development.rst . The other change the documentation to indicate that the PEtab YAML file becomes mandatory.

Required steps for changes to the PEtab specification

  • Updated format specifications (this PR)
  • Updated converter (no changes necessary)
  • Updated validator (no changes necessary)
  • Updated test suite (no changes necessary)
  • Updated changelog (this PR)

.github/ISSUE_TEMPLATE/petab-extensions.md Outdated Show resolved Hide resolved
.github/ISSUE_TEMPLATE/petab-extensions.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
doc/development.rst Outdated Show resolved Hide resolved
@dweindl
Copy link
Member

dweindl commented Nov 5, 2021

Here is a draft for the updated yaml schema to account for extensions that I created some time ago: https://github.com/PEtab-dev/libpetab-python/blob/yaml_schema_for_extensions/petab/petab_schema.yaml

@sonarcloud
Copy link

sonarcloud bot commented Nov 16, 2021

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot E 1 Security Hotspot
Code Smell A 1 Code Smell

No Coverage information No Coverage information
0.0% 0.0% Duplication

@FFroehlich FFroehlich changed the base branch from master to release/2.0.0 November 16, 2021 17:16
@FFroehlich FFroehlich marked this pull request as ready for review November 16, 2021 17:16
@dweindl dweindl linked an issue Nov 16, 2021 that may be closed by this pull request
doc/development.rst Outdated Show resolved Hide resolved
doc/development.rst Outdated Show resolved Hide resolved
doc/documentation_data_format.rst Outdated Show resolved Hide resolved
Co-authored-by: Yannik Schälte <31767307+yannikschaelte@users.noreply.github.com>
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PEtab Extensions
3 participants